Continuity mistake: As Indy swings through the window to rescue his father, he gets hit on the head by a vase. His hat is all crumpled and tipped quite far back, then in the very next shot his hat is neat and level.
Other mistake: When Marcus is knocked out at the library, look at his legs when he is dragged away - they are purposely crossed in a way which couldn't have happened naturally for a body being dragged - the actor did it to keep himself comfortable.
Continuity mistake: In the boat chase, when the bad guys are using machine guns, in one shot we see Indy's boat in the middle of the canal. In the next shot (close-up) they are very close to a large pile of dirt (or wood chips) and in the next (wide) shot they are in the middle of the canal again.
Factual error: During the motor boat chase through the canals of Venice, Dr. Schneider pilots the vessel between two ships, one identified as the John W. Mackay of London. Although the Mackay was commissioned in 1922, it was stationed at Halifax, Nova Scotia for service in the North Atlantic. It was deployed for the first time to the Mediterranean in 1942 - four years after the purported time of the movie.
Continuity mistake: When Indiana is showing Marcus the Grail Diary in his fathers home, he closes the book 4 times in a row without opening it - first 3 times inside the room, and then once on exit.
Continuity mistake: When Indy and Elsa escape underwater, and surface from the tunnel, Indy's suit should be drenched, but it only has water stains. Then during the speedboat chase, their clothes are completely dry.
Audio problem: In the boat fight scene, Kazim says something like "If you don't let me go, we both die" and Indy shouts "Then we'll die." But if you look at his lips, he's saying something else.
Continuity mistake: Indy falls off the side of the tank and gets his shoulder strap caught on the gun - this should not be possible because his shoulder strap is underneath his jacket, as can be seen when he gets back up onto the tank.
Continuity mistake: At the very end there is a large near circular blood stain on the left sleeve of Sean Connery's shirt. When they ride off, the stain has disappeared completely.
Continuity mistake: When the military caravan with Brody is driving through the canyon towards the Joneses and Sallah, the sun is behind Brody (discernable by the shade). But when Indy is looking down on them - from the front - the sun is also behind him.
Continuity mistake: The sky colour/condition changes between the shots of Indy and his father in line to get on board the Zeppelin and the scene just before. In one, it is cloudy, and in the other it is a clear blue.
Revealing mistake: When fire sweeps through the catacombs under the church, you can see that the "rats" are completely fake. At the far left of the screen (widescreen) you can see several fake rats just hanging on the wall and not moving at all. In the "special features" section on the DVD, Steven Spielberg admitted that the rats were fake - he couldn't bring himself to roast live ones so he could not make this scene appear realistic.
Factual error: There are no catacombs in Venice! There are also no natural petroleum sources - but that seems secondary to the fact that the entire city is just below sea level - there are no sewers, no subways - nothing underground.
Factual error: In various scenes, Dr. Elsa Schneider (Alison Doody) is wearing the M43 (Mountain Cap). That cap was introduced in 1943.
Continuity mistake: When Old Dr. Jones is holding Young Dr. Jones while he is reaching for the grail, watch Indy's left hand. In the shot from above, it is by his side, in the shot from below, he is holding the rock. It keeps switching from his side to the rock.
Continuity mistake: When the Nazi is strangling Indy with the chain, Indy looks down into the porthole of the tank and yells, "Dad!" Before he throws the gun down into the tank Indy's hat comes loose, but when the next shot is back on Indy, and he yells, "Dad! Dad, get out!" now his hat is back to normal.
Continuity mistake: After Sr. says "Let it go" as Indy is trying to get the grail, Indy is swinging and not being supported by the wall. The next camera angle shows him grasping the wall near his head. Switched back to Sr.'s view, he is again not holding the wall.
Other mistake: In the catacombs, Indy flips over the casket with the skeleton and dives underneath together with Elsa. If you watch closely, the skeleton gets trapped inside the casket, however Indy and Elsa are alone inside the casket. If the skeleton had sunken, there wasn't enough time, nor did Elsa or Indy bump into it when they dove underneath.
Revealing mistake: After Indy jumps onto the tank from the horse there's a shot where he stands up to face the bad guy if you look at the tracks on the sand behind him, they aren't caterpillar tracks but tyre tracks. The reason is that for the close-up shots a fake tank was built on top of a car, a security measure to avoid anyone getting hurt in case they fell off.
Answer: Henry says, in response to Indy asking if he remembered the details of the trials: "I wrote them down in my diary so that I wouldn't have to remember." So, obviously he did NOT know them by heart. Also, as the other answer says, they didn't want the diary to either be in the Nazis' possession or be burned.